Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency: helm, ivy #25

Closed
Ambrevar opened this issue Nov 10, 2017 · 5 comments
Closed

Consistency: helm, ivy #25

Ambrevar opened this issue Nov 10, 2017 · 5 comments

Comments

@Ambrevar
Copy link
Collaborator

I guess it would make sense for those bindings to be consistent.
Spacemacs has done some work in the area.

@jojojames
Copy link
Collaborator

Hmnn, which keys do you think are inconsistent?

I'm a little wary here because:

  1. I don't have any evil bindings set and ivy works fine for me.
  2. Helm is known to be a fairly inconsistent experience relative to emacs.

If we're trying to make it consistent, Helm is the one that needs to 'give way'.

@Ambrevar
Copy link
Collaborator Author

I'm thinking the motion key in the Ivy minibuffer, etc. For now Ivy only has ivy-occur bindings.

I do not know Ivy very well and it seems that you do not know Helm very well, so I guess we have some homework to do! :)

No problem with making Helm "give way" :)

@jojojames
Copy link
Collaborator

I used helm for a while until I settled on ivy and it definitely has a few different conventions to it. Ivy as a package is a lot more 'emacs'-like.

I'm not sure the ivy minibuffer needs evil keys (maybe it's just because I myself never use motion-related keys in the minibuffer).

@Ambrevar
Copy link
Collaborator Author

I suppose this would only make sense for people who use evil-minibuffer (like me! :p).

Let's keep this open for anyone to contribute. Otherwise I'll take a look at it when I have time.

@Ambrevar
Copy link
Collaborator Author

Ambrevar commented Dec 7, 2017

I've overhauled helm: most (all?) issues are fixed, many Evil classic are added, and it just happens that it matches Ivy bindings quite well.

There is still a lot of work to do, but that'll come with time.
I believe this can be closed for now.

@Ambrevar Ambrevar closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants