-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm-toggle-resplit-and-swap-windows cause window-live-p error #2424
Comments
Liangjie Lee ***@***.***> writes:
Expected behavior
After helm-toggle-resplit-and-swap-windows, action can still be done normally.
Actual behavior (from emacs-helm.sh if possible, see note above)
https://user-images.githubusercontent.com/32809182/120740857-9f7b0200-c526-11eb-8062-f13033679f86.mp4
Steps to reproduce (recipe)
From emacs-helm.sh:
1. C-h a (helm-apropos)
2. search some pattern, press C-t to switch layout
3. press RET -> window-live-p error
I can't reproduce on emacs-27.2. Recently many changes to
frame+minibuffer have been make on emacs master that make emacs behaving
differently with some core functions e.g. selected-frame,
exit-minibuffer, selected-window and so on, so I am not surprized to see
such error, I will switch to master with native comp as soon as possible
to see what's going on.
Thanks.
…--
Thierry
|
Liangjie Lee ***@***.***> writes:
Expected behavior
After helm-toggle-resplit-and-swap-windows, action can still be done normally.
Actual behavior (from emacs-helm.sh if possible, see note above)
https://user-images.githubusercontent.com/32809182/120740857-9f7b0200-c526-11eb-8062-f13033679f86.mp4
Steps to reproduce (recipe)
From emacs-helm.sh:
1. C-h a (helm-apropos)
2. search some pattern, press C-t to switch layout
3. press RET -> window-live-p error
After building an emacs-28 with native-compilation from last master
branch, I still can't reproduce.
Backtraces if any (M-x toggle-debug-on-error)
Can you have a backtrace?
Thanks.
…--
Thierry
|
Try rebuilding helm with your emacs, maybe it is a bad compilation problem. |
I update to the newest master commit and rebuild all my packages, the problem still exists. backtrace:
My Emacs build recipe:
|
Hmm, pretty sure it is a bug in Emacs related to the many last changes on minibuffer.c related to minibuffers and their windows and frames i.e. "Is this minibuffer belonging to this window or this frame?". So we will wait Emacs master to be more stable as it is a moving target actually. |
Note: to have a decent backtrace, you can eval helm.el (not helm.elc) and then reproduce the bug. |
Executed from emacs-helm.sh, the full backtrace are as below:
|
Liangjie Lee ***@***.***> writes:
Note: to have a decent backtrace, you can eval helm.el (not helm.elc) and then reproduce the bug.
Executed from emacs-helm.sh, the full backtrace are as below:
Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 89>)
[...]
Thanks for the full backtrace, this confirm what I said before, this
looks like a bug in Emacs or an incompatible change.
I could reproduce the bug with a recent build, don't know why I couldn't
reproduce with previous builds.
I can't make a change in Helm actually without breaking it on emacs-27
where it is working fine, let's see what emacs is going to to do, I
don't know for now how to make a decent bugreport for this, as soon as I
figure how to make a simple recipe working on 27 and failing on 28, I
will send a report.
Thanks.
…--
Thierry
|
The bug fix patch is included in the latest commit.emacs-mirror/emacs@6b40438 works for me. |
Great, thanks to confirm, closing now. |
Expected behavior
After
helm-toggle-resplit-and-swap-windows
, action can still be done normally.Actual behavior (from
emacs-helm.sh
if possible, see note above)helm-issue.mp4
Steps to reproduce (recipe)
From emacs-helm.sh:
C-h a
(helm-apropos)C-t
to switch layoutRET
-> window-live-p errorBacktraces if any (
M-x toggle-debug-on-error
)None
Describe versions of Helm, Emacs, operating system, etc.
Emacs: Master branch, commit 87e7390, configured with native-compilation
Helm: helm-20210531.709, helm-core-20210525.2002, installed from Melpa
OS: Debian sid
Are you using
emacs-helm.sh
to reproduce this bug? (yes/no):yes
The text was updated successfully, but these errors were encountered: