Support dart-sdk debugger instead of node debugger extension for dart-sdks that already support that

[zw963]

I create a new issue for tracing support builtin extension.

[ericdallo]

We can make lsp-dart check dart-version and use the dart-sdk debugger instead of the node one, but still use dap-mode to launch the process seems to be the better yet

[zw963]

Hi, @ericdallo , could you please give some professional advice for this thread?

I don't know what that client-id means too. 😄

[ericdallo]

I commented there

[zw963]

I commented there

Thanks for help on eglot, though, i switch back to lsp-dart (with lsp-ui disabled for performance issue), because eglot can not start correctly after i do rename on one of file of my project.

[ericdallo]

@zw963 I intend to implement this issue soon

[ericdallo]

@zw963 Done one master, could you confirm it works for you too so I can release a new version?
there is a new flag lsp-dart-dap-use-sdk-debugger that is t by default and will only work for dart SDK versions > 2.16.0.

[zw963]

@zw963 Done one master, could you confirm it works for you too so I can release a new version? there is a new flag lsp-dart-dap-use-sdk-debugger that is t by default and will only work for dart SDK versions > 2.16.0.

Okay, after a quick test, get some result, following is details:

 ╰─ $ flutter --version
Flutter 2.10.3 • channel unknown • unknown source
Framework • revision 7e9793dee1 (11 days ago) • 2022-03-02 11:23:12 -0600
Engine • revision bd539267b4
Tools • Dart 2.16.1 • DevTools 2.9.2

I try to test on flutter_sample on master branch.

For simple, i use linux desktop for test, so, i have to do like this to initialize it.

flutter precache -a
flutter config --enable-linux-desktop
flutter create --platforms=linux .

Then i can run flutter run -d linux succsssful from command line.

---

Now i start to test lsp-dart

1. use lsp-dart master branch code
2. run lsp-dart-dap-setup sucessful
3. keep lsp-dart-dap-use-sdk-debugger as default, that is true.
4. i can start lsp no error after enter dart-mode
5. But i get following error when i try to run lsp-dart-run and select linux.

Debugger entered--Lisp error: (error "No Content-Length header")
  error("No Content-Length header")
  (if content-length (string-to-number content-length) (error "No Content-Length header"))
  (let ((content-length (cdr (assoc "Content-Length" headers)))) (if content-length (string-to-number content-length) (error "No Content-Length header")))
  dap--get-body-length((("\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201..." . "/flutter.dev/go/android-project-migration\n\nto migrate your project. You may also pass the --ignore-deprecation flag to\nignore this check and continue ...") ("Content-Type" . "application/vscode-jsonrpc; charset=utf-8")))
  (let* ((header-raw (substring chunk 0 body-sep-pos)) (content (substring chunk (+ body-sep-pos 4))) (headers (mapcar 'dap--parse-header (split-string header-raw "\15\n"))) (body-length (dap--get-body-length headers))) (progn (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 3 headers))) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 5 t))) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 6 body-length))) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 7 0))) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 4 (make-string body-length 0)))) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 8 nil)))) (setq chunk content))
  (if body-sep-pos (let* ((header-raw (substring chunk 0 body-sep-pos)) (content (substring chunk (+ body-sep-pos 4))) (headers (mapcar 'dap--parse-header (split-string header-raw "\15\n"))) (body-length (dap--get-body-length headers))) (progn (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 3 headers))) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 5 t))) (progn (or (progn (and (memq ... cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 6 body-length))) (progn (or (progn (and (memq ... cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 7 0))) (progn (or (progn (and (memq ... cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 4 (make-string body-length 0)))) (progn (or (progn (and (memq ... cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 8 nil)))) (setq chunk content)) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 8 chunk))) (setq chunk ""))
  (let* ((body-sep-pos (string-match-p "\15\n\15\n" chunk))) (if body-sep-pos (let* ((header-raw (substring chunk 0 body-sep-pos)) (content (substring chunk (+ body-sep-pos 4))) (headers (mapcar 'dap--parse-header (split-string header-raw "\15\n"))) (body-length (dap--get-body-length headers))) (progn (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 3 headers))) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 5 t))) (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... p))) (let* ((v p)) (aset v 6 body-length))) (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... p))) (let* ((v p)) (aset v 7 0))) (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... p))) (let* ((v p)) (aset v 4 (make-string body-length 0)))) (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... p))) (let* ((v p)) (aset v 8 nil)))) (setq chunk content)) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 8 chunk))) (setq chunk "")))
  (if (not (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (aref p 5))) (let* ((body-sep-pos (string-match-p "\15\n\15\n" chunk))) (if body-sep-pos (let* ((header-raw (substring chunk 0 body-sep-pos)) (content (substring chunk (+ body-sep-pos 4))) (headers (mapcar 'dap--parse-header (split-string header-raw "\15\n"))) (body-length (dap--get-body-length headers))) (progn (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 3 headers))) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal ... ...)) (let* (...) (aset v 5 t))) (progn (or (progn ...) (signal ... ...)) (let* (...) (aset v 6 body-length))) (progn (or (progn ...) (signal ... ...)) (let* (...) (aset v 7 0))) (progn (or (progn ...) (signal ... ...)) (let* (...) (aset v 4 ...))) (progn (or (progn ...) (signal ... ...)) (let* (...) (aset v 8 nil)))) (setq chunk content)) (progn (or (progn (and (memq ... cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 8 chunk))) (setq chunk ""))) (let* ((total-body-length (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... p))) (aref p 6))) (received-body-length (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... p))) (aref p 7))) (chunk-length (string-bytes chunk)) (left-to-receive (- total-body-length received-body-length)) (this-body (substring chunk 0 (min left-to-receive chunk-length))) (leftovers (substring chunk (string-bytes this-body)))) (store-substring (progn (or (progn (and (memq ... cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (aref p 4)) received-body-length this-body) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 7 (+ (progn (or ... ...) (aref p 7)) (string-bytes this-body))))) (if (>= chunk-length left-to-receive) (progn (setq messages (cons (decode-coding-string (progn ... ...) 'utf-8) messages)) (dap--parser-reset p))) (setq chunk leftovers)))
  (while (not (string-empty-p chunk)) (if (not (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (aref p 5))) (let* ((body-sep-pos (string-match-p "\15\n\15\n" chunk))) (if body-sep-pos (let* ((header-raw (substring chunk 0 body-sep-pos)) (content (substring chunk (+ body-sep-pos 4))) (headers (mapcar 'dap--parse-header (split-string header-raw "\15\n"))) (body-length (dap--get-body-length headers))) (progn (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ... ...)) (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) ...) (let* ... ...)) (progn (or ... ...) (let* ... ...)) (progn (or ... ...) (let* ... ...)) (progn (or ... ...) (let* ... ...)) (progn (or ... ...) (let* ... ...))) (setq chunk content)) (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... p))) (let* ((v p)) (aset v 8 chunk))) (setq chunk ""))) (let* ((total-body-length (progn (or (progn ...) (signal ... ...)) (aref p 6))) (received-body-length (progn (or (progn ...) (signal ... ...)) (aref p 7))) (chunk-length (string-bytes chunk)) (left-to-receive (- total-body-length received-body-length)) (this-body (substring chunk 0 (min left-to-receive chunk-length))) (leftovers (substring chunk (string-bytes this-body)))) (store-substring (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... p))) (aref p 4)) received-body-length this-body) (progn (or (progn (and (memq ... cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (let* ((v p)) (aset v 7 (+ (progn ... ...) (string-bytes this-body))))) (if (>= chunk-length left-to-receive) (progn (setq messages (cons (decode-coding-string ... ...) messages)) (dap--parser-reset p))) (setq chunk leftovers))))
  (let* ((messages 'nil) (output (encode-coding-string output 'utf-8 'nocopy)) (chunk (concat (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list ... p))) (aref p 8)) output))) (while (not (string-empty-p chunk)) (if (not (progn (or (progn (and (memq (type-of p) cl-struct-dap--parser-tags) t)) (signal 'wrong-type-argument (list 'dap--parser p))) (aref p 5))) (let* ((body-sep-pos (string-match-p "\15\n\15\n" chunk))) (if body-sep-pos (let* ((header-raw (substring chunk 0 body-sep-pos)) (content (substring chunk (+ body-sep-pos 4))) (headers (mapcar 'dap--parse-header (split-string header-raw "\15\n"))) (body-length (dap--get-body-length headers))) (progn (progn ... ...) (progn ... ...) (progn ... ...) (progn ... ...) (progn ... ...) (progn ... ...)) (setq chunk content)) (progn (or (progn ...) (signal ... ...)) (let* (...) (aset v 8 chunk))) (setq chunk ""))) (let* ((total-body-length (progn (or ... ...) (aref p 6))) (received-body-length (progn (or ... ...) (aref p 7))) (chunk-length (string-bytes chunk)) (left-to-receive (- total-body-length received-body-length)) (this-body (substring chunk 0 (min left-to-receive chunk-length))) (leftovers (substring chunk (string-bytes this-body)))) (store-substring (progn (or (progn ...) (signal ... ...)) (aref p 4)) received-body-length this-body) (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... p))) (let* ((v p)) (aset v 7 (+ ... ...)))) (if (>= chunk-length left-to-receive) (progn (setq messages (cons ... messages)) (dap--parser-reset p))) (setq chunk leftovers)))) (nreverse messages))
  dap--parser-read(#s(dap--parser :waiting-for-response nil :response-result nil :headers nil :body nil :reading-body nil :body-length nil :body-received 0 :leftovers "\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201\342\224\201...") "Content-Length: 517\15\nContent-Type: application/vsc...")
  (mapc #'(lambda (m) (let* ((parsed-msg (dap--read-json m)) (key (gethash "request_seq" parsed-msg nil))) (if dap-print-io (progn (let ((inhibit-message dap-inhibit-io)) (message "Received:\n%s" (dap--json-encode parsed-msg))))) (condition-case _ (let* ((val (gethash "type" parsed-msg))) (cond ((equal val '"event") (let nil (dap--on-event debug-session parsed-msg))) ((equal val '"response") (let nil (let* ((callback (and t (gethash key handlers nil)))) (if callback (progn (funcall callback parsed-msg) (remhash key handlers) (run-hook-with-args 'dap-executed-hook debug-session (gethash "command" parsed-msg))) (message "Unable to find handler for %s." (pp parsed-msg)))))) ((equal val '"request") (let nil (dap--start-process debug-session parsed-msg))))) (quit)))) (dap--parser-read parser msg))

6. after (setq lsp-dart-dap-use-sdk-debugger nil), it seem like work fine.

---

Following is my minimum config which can reproduce above issue:

(require 'company)
(require 'lsp-mode)
(require 'lsp-modeline)
(require 'lsp-headerline)
(require 'lsp-diagnostics)
(require 'dart-mode)
(require 'dap-mode)
(require 'dap-ui)
(require 'dap-mouse)
(add-to-list 'auto-mode-alist '("\\.dart\\'" . dart-mode))
(require 'lsp-dart)
;; (setq lsp-dart-dap-use-sdk-debugger nil)
(add-hook 'dart-mode-hook 'lsp-deferred)

---

Folowing is logs:

lsp-log

Command "/home/zw963/flutter/bin/cache/dart-sdk/bin/dart /home/zw963/flutter/bin/cache/dart-sdk/bin/snapshots/analysis_server.dart.snapshot --lsp --client-id emacs.lsp-dart --client-version 1.21.0" is present on the path.
Command "/home/zw963/flutter/bin/cache/dart-sdk/bin/dart /home/zw963/flutter/bin/cache/dart-sdk/bin/snapshots/analysis_server.dart.snapshot --lsp --client-id emacs.lsp-dart --client-version 1.21.0" is present on the path.
Found the following clients for /home/zw963/Dart/flutter_sample/lib/main.dart: (server-id dart_analysis_server, priority 1)
The following clients were selected based on priority: (server-id dart_analysis_server, priority 1)

flutter daemon

[{"event":"daemon.connected","params":{"version":"0.6.1","pid":43074}}]
[{"event":"daemon.logMessage","params":{"level":"status","message":"Starting device daemon..."}}]
[{"id":59606}]
[{"event":"device.added","params":{"id":"linux","name":"Linux","platform":"linux-x64","emulator":false,"category":"desktop","platformType":"linux","ephemeral":false,"emulatorId":null}}]
[{"id":28109,"result":[{"id":"Galaxy_Nexus_API_31","name":"Galaxy Nexus API 31","category":"mobile","platformType":"android"},{"id":"Nexus_6P_API_31","name":"Nexus 6P API 31","category":"mobile","platformType":"android"}]}]

[ericdallo]

It does work for me, not sure why that exception happens for you, also you don't need lsp-dart-dap-setup anymore if using that new flag.
All those pasted logs are unrelated to DAP, only the exception, we would need DAP communication logs, @yyoncho any suggestions here?

[zw963]

It does work for me, not sure why that exception happens for you, also you don't need lsp-dart-dap-setup anymore if using that new flag.

Remove json extension, keep default config, get same error.

BTW, are you try with my version flutter and dart?

I am current test it use flutter git tag 2.10.3, maybe you can reproduce after check it out.

[ericdallo]

I'm using latest stable flutte which is 2.10.3.

[zw963]

I'm using latest stable flutter which is 2.10.3.

It works for me now, i guess some network issue happen when i last time use 2.10.3 and run flutter pub get

anyway, i fix it by:

1. git checkout to flutter newest master
2. run flutter pub get in flutter_sample project, until it success.
3. i found it works on master
4. switch back to 2.10.3
5. it start to works.

Then i get a error when i test on flutter_sample project, like this.

I guess this package:flutter_lints/flutter.yaml was created when i initialize my linux desktop, but, it seem like not broken lsp-dart-run, i don't know if this is a issue, just report here, please check.

Another issue is, lsp-dart-dap-flutter-hot-reload/restart command just not works for me, noop.

[zw963]

Sorry for confusing!

i think flutter_sample still not works for me on 2.10.3, but it works on master anyway, i am messed up the branch just now, but, i can confirm
new dart analysis server works on our (bigger) project well on 2.10.3, even lsp-dart-dap-flutter-hot-reload/restart works on our project too, i guess because "No Content-Length header" issue cause hot reload/restart not work.

I don't know why this, but maybe a network issue or just flutter_sample project specified issue, i will reset all my local download cache when i free recent days.

BTW, there is no any log/info output when run lsp-dart-run, i consider this should be a issue, because there no current progress, and even, when i do print('1111111111111111111111111') on dart file, can't see those log, could you please check that?

BTW: then switch to master, dart give us far more warning messages which need to fix then current 2.10.3

[ericdallo]

@zw963 , made one more commit fixing the output, besides that, I think everything is right, could you test that specifically?
If that works, I think we can do a release

[zw963]

made one more commit fixing the output, besides that, I think everything is right, could you test that specifically?
If that works, I think we can do a release

Okay, i will new feature today full day, will be touch if any issue.

[zw963]

Hi, i consider will do test completely after you fix the output, because, lsp-dart-run not work again on my another laptop.

It seem like struke by some command, as you can see from ps output:

there is no clue about what happening if no log.

---

UPDATED:

after kill all process and restart emacs again, lsp-dart-run successful anyway.

[zw963]

Don't know if this is issue.

NavigationRailLabelType is a Enum, only none, selected, all is available, but it show to many member.

[ericdallo]

Yeah, I already fixed the output, there is nothing to fix related to that AFAIK.

Don't know if this is issue.

If it's an issue, certainly a server issue. feel free to open an issue on dart-sdk.

[zw963]

Yeah, I already fixed the output, there is nothing to fix related to that AFAIK.

Yes, i saw the log now, though, there seem like still less output then before, e.g. current selected device info etc.

And, still no chance to test if #145 work.

If it's an issue, certainly a server issue. feel free to open an issue on dart-sdk

It's my fault, i change some settings of company-backends several days ago, which cause this.

---

There still have one more issue, though, maybe not relative to this update.

i fork flutter_sample project here, you can try reproduce on test_jump_to_definition branch.

Following is reproduce:

1. switch to test_jump_to_definition branch
2. open lib/main.dart, hover on Dashboard, as screenshot.
   
3. try jump to definition. (xref-find-definitions), it jump to lib/screens/dashboard/dashboard.dart, it works!
4. hover on DesktopMultiWindow, try jump to def, it jump to ~/.pub-cache/hosted/pub.flutter-io.cn/desktop_multi_window-0.0.1/lib/desktop_multi_window.dart:11, it still works!
5. at this time, lsp give me a selection. like following screenshot.
   
   I select to set root directory interactively, that is, ~/.pub-cache/hosted/pub.flutter-io.cn/desktop_multi_window-0.0.1, i consider this is the correct option, right? please point out if this is not intended. from my point, if not set lsp root, there is no way to continue jump to next definition.
6. hover on multiWindowChannel, jump to definition, it goto ~/.pub-cache/hosted/pub.flutter-io.cn/desktop_multi_window-0.0.1/lib/src/channels.dart, it seem like sitll works, though, as you can see, many flycheck error on this file.

7. now my issue is coming. when hover on MethodChannel, it can't jump to definition. (but can when use VSCode)
   

[ericdallo]

I'm aware of this and not sure how to improve it, but please open a new issue.