Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] run lsp-dart-run automatically when run lsp-dart-dap-flutter-hot-reload/restart? #143

Closed
zw963 opened this issue Feb 7, 2022 · 7 comments

Comments

@zw963
Copy link

zw963 commented Feb 7, 2022

This was not a bug, just a discuss.

because i binding lsp-dart-dap-flutter-hot-restart to a keybinding, so, i expected to this command(and ???-hot-reload) command can start lsp-dart-run automatically when i pressing my keybinding, that should be a reasonable default too, and, if user do native desktop development, it is more easy to terminate current app then emulator, which cause user have to run lsp-dart-run manually again.

Thank you.

@ericdallo
Copy link
Member

If I understood it correctly, you want lsp-dart-dap-flutter-hot-restart/lsp-dart-dap-flutter-hot-reload to run lsp-dart-run automatically if no session is running yet?

@zw963
Copy link
Author

zw963 commented Feb 7, 2022

If I understood it correctly, you want lsp-dart-dap-flutter-hot-restart/lsp-dart-dap-flutter-hot-reload to run lsp-dart-run automatically if no session is running yet?

Yes, i think if we can more better, 😄, in fact, hover.el do things like this, right?

@ericdallo
Copy link
Member

yes, feel free to open a PR

@zw963
Copy link
Author

zw963 commented Feb 11, 2022

In fact, this one is too hard for me to contribute ... sorry.

@ericdallo
Copy link
Member

@zw963 done on commit above, could you confirm later?

@zw963
Copy link
Author

zw963 commented Feb 14, 2022

@zw963 done on commit above, could you confirm later?

It works when after start emacs, run lsp-dart the first time, Cool!

but, it seem like not works if start then terminate.

Following is reproduce use linux desktop:

  1. run lsp-dart-dap-flutter-hot-restart to start linux desktop, it works.
  2. because some reason, i close my linux desktop app.
  3. try run lsp-dart-dap-flutter-hot-restart
  4. I get a message: dap--send-message: Session Flutter Run is already terminated

thank you very much.

@ericdallo
Copy link
Member

Hum, this sounds like a dap-mode bug :( Not sure there is anything to do on lsp-dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants