Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider sending didChangeConfiguration when settings change. #1174

Open
muirdm opened this issue Nov 12, 2019 · 3 comments
Open

Consider sending didChangeConfiguration when settings change. #1174

muirdm opened this issue Nov 12, 2019 · 3 comments

Comments

@muirdm
Copy link
Contributor

muirdm commented Nov 12, 2019

Some servers support dynamically updating server config settings. It would be cool if we automatically sent "workspace/didChangeConfiguration" notifications when a user updates a custom setting variable or calls lsp-register-custom-settings directly. Currently AFAIK the user must restart the server after changing settings.

@yyoncho
Copy link
Member

yyoncho commented Nov 12, 2019

It will be a nice improvement, we could do it by:

  1. Adding association server->section(s) in lsp--client. AFAIK vscode clients declare which sections to synchronize.
  2. Emacs 26 has :get and :set (see https://www.gnu.org/software/emacs/manual/html_node/elisp/Variable-Definitions.html) which could be used to update find the servers and update them.

@michaelpj
Copy link
Contributor

This would be nice to have! We have to stick a little warning in at the moment that you have to restart the server to pick up settings.

Doing 1 would have some other benefits, e.g. some informative commands like lsp-describe-session could also point people towards the right setting customization group.

@yyoncho yyoncho self-assigned this Oct 22, 2021
@yyoncho
Copy link
Member

yyoncho commented Oct 23, 2021

Posted a PR at #3167 . We have to migrate all properties to use defcustom-lsp and then configure the client which sections it wants to have synched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants