Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treemacs will not expand #137

Closed
invisiblegaudi opened this issue Sep 13, 2022 · 7 comments
Closed

Treemacs will not expand #137

invisiblegaudi opened this issue Sep 13, 2022 · 7 comments

Comments

@invisiblegaudi
Copy link

invisiblegaudi commented Sep 13, 2022

When I use the lsp-treemacs-references, the tab in the buffer below appears, with the count but it won't expand - when I tab over it, it just replicates across the minibuffer. Experiencing this on both OSX and Ubuntu. Using spacemacs flavour. Previous to this after an update, I noticed the tab/results design changed and it would replicate once only and then expand. This is an essential tool for refactoring, I am reduced to helm-projectile-rg-ing everything now to find the references 😭

@RidaAyed
Copy link

RidaAyed commented Sep 15, 2022

Same here after updating spacemacs packages. Rolling back the package updates fixes the problem.

No issues with state before update:

System Info before update 💻

LSP :: lsp-mode 20220815.958, Emacs 28.2, gnu/linux
[Treemacs] v2.10 (installed 2022.08.15) @ Emacs 28.1

  • OS: gnu/linux
  • Emacs: 28.2
  • Spacemacs: 0.999.0
  • Spacemacs branch: develop (rev. e37e8e227)
  • Graphic display: t
  • Running in daemon: nil
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: ivy
  • Layers:
((treemacs :variables treemacs-use-follow-mode t treemacs-use-filewatch-mode t treemacs-use-git-mode 'simple treemacs-use-all-the-icons-theme t)
 )

@yyoncho
Copy link
Member

yyoncho commented Sep 15, 2022

Can you try using treemacs from melpa stable? There is a breaking change in treemacs itself. (before that you may also need to wipe lsp-treemacs)

@timfel
Copy link
Contributor

timfel commented Sep 15, 2022

Throwing out my .emacs.d and starting fresh, but this time installing treemacs from melpa-stable didn't help. Afaics, they updated the version in melpa stable again just after the breaking change

@yyoncho
Copy link
Member

yyoncho commented Sep 15, 2022

Yep, you have to pit to the 2.11 commit.

I am working on a fix, it will be available soon(I hope tomorrow)

@yyoncho
Copy link
Member

yyoncho commented Sep 18, 2022

It should be good now. The only thing that is broken is automatic expansion, I will fix it once we have the corresponding piece on treemacs side

@timcharper
Copy link

For packages which still refer to lsp-treemacs-initialize, what should they call now?

https://github.com/emacs-lsp/lsp-mssql/blob/88319a61a06e27fc1d3ea2e7b853ec1692b4c166/lsp-mssql.el#L607

emacs-lsp/lsp-mssql#17

@yyoncho
Copy link
Member

yyoncho commented Feb 7, 2023

@timcharper they should be rewritten to use lsp-treemacs-render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants