Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not doing the same matching* as Helm already does #9

Open
danielkrizian opened this issue Jun 8, 2021 · 0 comments
Open

not doing the same matching* as Helm already does #9

danielkrizian opened this issue Jun 8, 2021 · 0 comments

Comments

@danielkrizian
Copy link
Collaborator

Especially since:
a) helm-q does four times the number of regex calls for that;
b) helm-q does > only a subset of Helm's matching, and
c) helm-q's matching is called after Helm's, so is guaranteed to run on items that don't match its criteria, with the number of items likely being the majority of the 15000.

  • matching on the main parameters of the connection, which are displayed in the results: address, region, environment and service—since Helm does its matching on the string merged from these params. So it remains for helm-q to check only the tables, columns, functions and variables, which are normally hidden from view and thus are untouched by Helm.
@danielkrizian danielkrizian created this issue from a note in Project Board (To do) Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Project Board
  
To do
Development

No branches or pull requests

1 participant