Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support minor modes that rely on font-lock-mode #45

Closed
ubolonton opened this issue Jun 12, 2020 · 0 comments · Fixed by #47
Closed

Support minor modes that rely on font-lock-mode #45

ubolonton opened this issue Jun 12, 2020 · 0 comments · Fixed by #47

Comments

@ubolonton
Copy link
Collaborator

ubolonton commented Jun 12, 2020 •
edited

Currently tree-sitter-hl-mode disables all of font-lock-mode's highlighting.

It should instead disable only patterns set by the major mode, i.e. font-lock-defaults, and respect patterns added by minor modes and end users (through font-lock-add-keywords).

Note: This is a bit tricky, as the way font-lock-mode supports custom patterns is messy. See e.g. font-lock-refresh-defaults.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support minor modes that use font-lock-add-keywords emacs-tree-sitter/elisp-tree-sitter
1 participant
@ubolonton