Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Android 13 #231

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

Conversation

ArnyminerZ
Copy link
Contributor

Type of change

  • Bug fix
  • New feature
  • Translation

Migrations made

  • Location permissions change (Android 12 - Docs).
  • Updated AGP to 7.3.1
  • Updated target and compile SDK to 33
  • Updated to Gradle 7.4
  • Using per-app language preferences (Android 13 - Docs)
  • Updated dependencies

Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
@ArnyminerZ ArnyminerZ changed the title WIP: Migration to Android 13 Migration to Android 13 Nov 25, 2022
@emansih
Copy link
Owner

emansih commented Nov 27, 2022

Hi, thanks for your contribution. This is quite a big MR. I am hesistant to merge it without doing a thorough review of the commits. I will merge this in due time.

@ArnyminerZ
Copy link
Contributor Author

I'll use this as a daily driver, to check if it has any major issues.

@emansih
Copy link
Owner

emansih commented Dec 16, 2022

Hi @ArnyminerZ . I pulled your changes to my local machine and I can't build it.

e: C:\FireflyMobile\app\src\main\java\xyz\hisname\fireflyiii\workers\AttachmentWorker.kt: (49, 58): Cannot access class 'com.google.common.util.concurrent.ListenableFuture'. Check your module classpath for missing or conflicting dependencies
e: C:\FireflyMobile\app\src\main\java\xyz\hisname\fireflyiii\workers\AttachmentWorker.kt: (49, 140): Unresolved reference. None of the following candidates is applicable because of receiver type mismatch:
public operator fun MatchGroupCollection.get(name: String): MatchGroup? defined in kotlin.text

@ArnyminerZ
Copy link
Contributor Author

Yup, Guava is giving problems. Sometimes it does build, other times it just doesn't. I've tried different approaches, there's even a package Google released exclusively for this fix, but nothing works all the times :/

I was waiting for Google to release a fix.

Copy link
Owner

@emansih emansih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello this commit has "too many" changes that are whitespaces. The only "real" change is

if (isPermissionGranted(Manifest.permission.ACCESS_COARSE_LOCATION)) {
        }

Could you please make sure the formatting is updated before I pull this commit? Thanks for your contribution

Copy link
Owner

@emansih emansih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need COARSE_LOCATION permission here since we have already requested FINE_LOCATION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants