Implement filtering requests by method #19
Conversation
| @@ -91,6 +92,7 @@ impl HttpHandler for Output { | |||
|
|
|||
| #[derive(Clone, Debug)] | |||
| pub struct OutputRequest { | |||
| http_method: Method, | |||
| method: String, | |||
There was a problem hiding this comment.
Here, I wasn't sure why the items were converted into Strings. My guess is to stop heap allocations each frame or a similar performance concern, but if not, then maybe the http_method field is an adequate replacement for the existing methodfield.
There was a problem hiding this comment.
A rude truth: string conversions sucks and it is bad practice in this case but it was my first approach to gui and as the first versions was comfortable. One fo the next steps is to avoid the String conversion on everything. For now thank you very much for your effort, i review the code today.
That would be great! |
|
Awesome, the issue is #20 I hope I have made myself clear in the description |
Hello! My name is Marcel and I'm a recent Bachelor's graduate and Rust enthusiast 馃. I saw your posting on TWIR Call for Participation, and it seemed like a perfect avenue for my first open source contribution, closes #6.
feature.method_filter.demo.mov
I did my best to maintain the existing inline style of the code, and no keep the filter minimally intrusive visually. Please let me know if there's anything you'd like me to change :)