Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global underscore used when engine is specified and using imports #22

Open
demerzel3 opened this issue Sep 29, 2016 · 2 comments · May be fixed by #23
Open

Global underscore used when engine is specified and using imports #22

demerzel3 opened this issue Sep 29, 2016 · 2 comments · May be fixed by #23

Comments

@demerzel3
Copy link

An interesting bug arises when both engine and imports are used: imports are correctly loaded from the specified engine and passed to the template function, but the _ symbol inside of the template function refers to the global _ instead of the engine's one.

I pinned down the problem to the usage of the Function() syntax, here's a CodePen to prove my point: http://codepen.io/anon/pen/JRybKm?editors=0012

I think it can be easily solved by passing the engine directly in the call to Function alongside the other imports, I will file a PR to fix it soon.

@SpaceK33z
Copy link
Collaborator

I think this is somewhat related to #19. I'm interested in your PR though :).

@SpaceK33z
Copy link
Collaborator

And also related to #13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants