fix(requestOption): stop caching headers

caching caused the x-ems-header to get out of date
emartech · Jan 29, 2018 · bc37793 · bc37793
1 parent adc9fcc
commit bc37793
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/requestOption.js b/lib/requestOption.js
@@ -89,7 +89,7 @@ class SuiteRequestOption {
     const hash = {
       port: this.port,
       host: this.host,
-      headers: this.headers,
+      headers: this.headers.slice(0),
       prefix: this.prefix,
       timeout: this.timeout,
       maxContentLength: this.maxContentLength

diff --git a/lib/requestOption.spec.js b/lib/requestOption.spec.js
@@ -137,6 +137,12 @@ describe('SuiteRequestOption', function() {
 
       expect(requestOptions.toHash()).to.have.property('allowEmptyResponse', true);
     });
+
+    it('should not cache headers', function() {
+      const requestOptions = new SuiteRequestOption(dummyServiceConfig.host, dummyServiceConfig);
+      requestOptions.toHash().headers.push('from_test');
+      expect(requestOptions.toHash().headers).not.to.include('from_test');
+    });
   });
 
 });