Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal map exists but reliefs are missing #49

Closed
SamuelTallet opened this issue Feb 11, 2022 · 4 comments · Fixed by #50
Closed

Normal map exists but reliefs are missing #49

SamuelTallet opened this issue Feb 11, 2022 · 4 comments · Fixed by #50
Labels
bug Something isn't working

Comments

@SamuelTallet
Copy link

Hello,

First thing, thanks for your awesome work!
I have an issue with this glTF model. According to glTF Report app the model is valid:

T-Rex - glTF Report - Valid

Its reliefs appear:

T-Rex - glTF Report

But Kajiya seems to ignore its normal map:

T-Rex - Kajiya

Technical details:

  • Kajiya (latest)
  • Windows 10
  • GTX 1060 6GB
@SamuelTallet SamuelTallet added the bug Something isn't working label Feb 11, 2022
@h3r2tic
Copy link
Collaborator

h3r2tic commented Feb 11, 2022

Hey! Looks like the asset is missing vertex tangents, which are needed for normal mapping, and which kajiya does not auto-generate right now.

@SamuelTallet
Copy link
Author

I don't know if it can help... A Rust implementation of Mikkelsen Tangent Space Algorithm exists.

@h3r2tic
Copy link
Collaborator

h3r2tic commented Feb 12, 2022

Yup, that was very easy to plug in, thanks 😀

image

Still lacks feathers, but I guess we can tackle biological accuracy in another issue 😜

@SamuelTallet
Copy link
Author

Great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants