Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be good to audit interrupt logic #154

Closed
derekdreery opened this issue May 1, 2021 · 1 comment
Closed

Would be good to audit interrupt logic #154

derekdreery opened this issue May 1, 2021 · 1 comment

Comments

@derekdreery
Copy link
Contributor

I had some trouble with an earlier version of embassy because I hit a data race in the way that the interrupts was set to trigger. That issues is fixed now, AFAICT when I look at the code, but I think someone should do a detailed audit of the logic at some point. It's the kind of thing where you can't just wait for bug reports, because if it does cause problems they will be very rare and difficult to reproduce, since they rely on timing.

This isn't a criticism of the code, which looks good, but just a note that an audit would be worthwhile sometime in the future when the codebase has stabilized a bit.

@Dirbaio
Copy link
Member

Dirbaio commented Feb 13, 2022

I'm going to close this as "not actionable". The exact work tracked here is too vague. Also, almost a year has passed, and the interrupt stuff is quite in a good shape now IMO. It's been a while since I've seen a Waker irq race bug.

@Dirbaio Dirbaio closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants