Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Custom Ollama endpoint base_url #1301

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

felipeavilis
Copy link
Contributor

Description

Langchain includes Ollama's base_url for localhost on the default port 11434, but in our case it runs on a different server than Embedchain. We needed to allow customization of this address, so we changed the necessary files to include the custom address to the YAML configuration file.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

Create a Ollama server and point the YAML config value "base_url" to the server.

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Made sure Checks passed

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.85%. Comparing base (c77a75d) to head (304f694).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
- Coverage   55.85%   55.85%   -0.01%     
==========================================
  Files         153      153              
  Lines        6169     6171       +2     
==========================================
+ Hits         3446     3447       +1     
- Misses       2723     2724       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj
Copy link
Collaborator

deshraj commented Mar 5, 2024

Thanks for adding support for this.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 5, 2024
@deshraj deshraj merged commit 6078738 into embedchain:main Mar 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants