Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itemLagReduction is incompatible with Ships Mod #38

Closed
syndicate25 opened this issue Sep 19, 2022 · 13 comments
Closed

itemLagReduction is incompatible with Ships Mod #38

syndicate25 opened this issue Sep 19, 2022 · 13 comments
Labels
bug Something isn't working low priority Valid issue, but not currently a high priority

Comments

@syndicate25
Copy link

Using the latest 0.3.2 version, dropped items float to the ground so slowly, if I don't move out of their way, I pick them up again.

Problem does not occur without ArchaicFix installed.

I don't recall this as an issue in 0.3.0, but I can test that tomorrow if needed.

Here's a short video I took:
https://youtu.be/xYTh0cUA2U0

@quentin452
Copy link

mods list?

@syndicate25
Copy link
Author

Mod List

@quentin452
Copy link

quentin452 commented Sep 19, 2022

try deleting [1.7.10]BugPatch

@syndicate25
Copy link
Author

syndicate25 commented Sep 19, 2022

Removed BugPatch. No change, still slowly floating to the ground.

EDIT: Had some extra time today so I'm testing by removing/adding mods til I find the one that's causing a conflict with ArchaicFix. Still not sure which end it's going to be on, but I'll update when I find which mod it is.

@syndicate25
Copy link
Author

It's a conflict between ArchaicFix and Ships mod.

Is there anything you can check on your end to see if it can be resolved? I know Ships is not getting any more updates, so any help would be appreciated.

@embeddedt
Copy link
Owner

embeddedt commented Sep 19, 2022

I will see if I can make it work properly, if not I will add a config to disable the optimization which causes this. Apparently the config already exists, see below. (I am too busy nowadays. 😆)

@syndicate25
Copy link
Author

So it appears it may be also causing an item dup glitch. See latest video:

https://youtu.be/hv-YgFmymnc

@syndicate25 syndicate25 changed the title Floating items Floating items/Item dup glitch Sep 20, 2022
@embeddedt
Copy link
Owner

embeddedt commented Sep 20, 2022

Weird. All that's being done is to throttle how often the item moves when it is stationary (somehow this other mod must cause the item to seem stationary to my code), so I'm not sure why that would allow duplication.

@makamys
Copy link
Collaborator

makamys commented Sep 20, 2022

Can you (syndicate) check if disabling itemLagReduction fixes anything? That should disable the aforementioned code.

@syndicate25
Copy link
Author

Weird. All that's being done is to throttle how often the item moves when it is stationary (somehow this other mod must cause the item to seem stationary to my code), so I'm not sure why that would allow duplication.

That actually would make sense since it allows you to make moving ships in the game, so it must have to convince MC that your stuff is not moving while on the ship.

Can you (syndicate) check if disabling itemLagReduction fixes anything? That should disable the aforementioned code.

I'll give that a try and let you know if it is fixed.

@syndicate25
Copy link
Author

Looks like that has solved the issue with the floating items. I haven't been able to reproduce the item duping yet either since items are no longer falling slow enough to be caught mid-air.

Any chance of a fix on that section of the code to be able to use itemLagReduction in the future?

@embeddedt
Copy link
Owner

Possibly, but it will be a while, as I have very little time to devote to the mod right now.

@embeddedt embeddedt added bug Something isn't working low priority Valid issue, but not currently a high priority labels Nov 6, 2022
@embeddedt embeddedt changed the title Floating items/Item dup glitch itemLagReduction is incompatible with Ships Mod Nov 6, 2022
@makamys
Copy link
Collaborator

makamys commented Dec 24, 2022

Telomerase's Ships Mod fork just received a patch that makes the movement hook less intrusive (TeloDev/Cuchaz-Ships#2). It might be worth checking if itemLagReduction is compatible with it now (this could be tested with ArchaicFix 0.3.2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority Valid issue, but not currently a high priority
Projects
None yet
Development

No branches or pull requests

4 participants