Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the model similarity instead of benchmark defined similarity #885

Closed
KennethEnevoldsen opened this issue Jun 5, 2024 · 0 comments · Fixed by #931
Closed

Use the model similarity instead of benchmark defined similarity #885

KennethEnevoldsen opened this issue Jun 5, 2024 · 0 comments · Fixed by #931
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@KennethEnevoldsen
Copy link
Contributor

We currently use a similarity metric decided by the benchmark instead of by the model (also discussed in #766). Sentence transformers v3 allow for using a custom similarity metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant