Removing unnecessary encodeURIComponent and decodeURIComponent calls (f…

…ixes #6)
embedly · May 10, 2012 · 3be205d · 3be205d
1 parent c2d24f5
commit 3be205d
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/jquery.preview.full.js b/jquery.preview.full.js
@@ -2160,8 +2160,8 @@ function Preview(elem, options) {
           }
           obj.image_url = v;
         }
-        else{
-          v = obj.hasOwnProperty(n) && obj[n] ? encodeURIComponent(obj[n]): '';
+        else {
+          v = obj[n];
         }
 
         var d = {
@@ -2243,7 +2243,7 @@ function Preview(elem, options) {
       // input that we should look for and compare values. If they are the
       // same we will ignore.
       var original_url = this.form.find('#id_original_url').val();
-      if (original_url === encodeURIComponent(url)) {
+      if (original_url === url) {
         return true;
       }
 
@@ -2292,7 +2292,7 @@ function Preview(elem, options) {
         function (i, e) {
           var n = $(e).attr('name');
           if (n !== undefined) {
-            data[n] = decodeURIComponent($(e).val());
+            data[n] = $(e).val();
           }
       });
       // Clears the Selector.

diff --git a/jquery.preview.full.min.js b/jquery.preview.full.min.js
diff --git a/jquery.preview.js b/jquery.preview.js
@@ -903,8 +903,8 @@ function Preview(elem, options) {
           }
           obj.image_url = v;
         }
-        else{
-          v = obj.hasOwnProperty(n) && obj[n] ? encodeURIComponent(obj[n]): '';
+        else {
+          v = obj[n];
         }
 
         var d = {
@@ -986,7 +986,7 @@ function Preview(elem, options) {
       // input that we should look for and compare values. If they are the
       // same we will ignore.
       var original_url = this.form.find('#id_original_url').val();
-      if (original_url === encodeURIComponent(url)) {
+      if (original_url === url) {
         return true;
       }
 
@@ -1035,7 +1035,7 @@ function Preview(elem, options) {
         function (i, e) {
           var n = $(e).attr('name');
           if (n !== undefined) {
-            data[n] = decodeURIComponent($(e).val());
+            data[n] = $(e).val();
           }
       });
       // Clears the Selector.

diff --git a/jquery.preview.min.js b/jquery.preview.min.js
diff --git a/src/preview.js b/src/preview.js
@@ -181,8 +181,8 @@ function Preview(elem, options) {
           }
           obj.image_url = v;
         }
-        else{
-          v = obj.hasOwnProperty(n) && obj[n] ? encodeURIComponent(obj[n]): '';
+        else {
+          v = obj[n];
         }
 
         var d = {
@@ -264,7 +264,7 @@ function Preview(elem, options) {
       // input that we should look for and compare values. If they are the
       // same we will ignore.
       var original_url = this.form.find('#id_original_url').val();
-      if (original_url === encodeURIComponent(url)) {
+      if (original_url === url) {
         return true;
       }
 
@@ -313,7 +313,7 @@ function Preview(elem, options) {
         function (i, e) {
           var n = $(e).attr('name');
           if (n !== undefined) {
-            data[n] = decodeURIComponent($(e).val());
+            data[n] = $(e).val();
           }
       });
       // Clears the Selector.