Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Ember 2.8 (attributeBindings on tag-less component: liquid-if) #500

Closed
deepflame opened this issue Sep 13, 2016 · 8 comments
Closed

Comments

@deepflame
Copy link

Hi everyone,

experiencing the following error with liquid-fire 0.25 and Ember 2.8 after upgrade:

ember.debug.js:6778 Uncaught Error: Assertion Failed: 
You cannot use `attributeBindings` on a tag-less component: <awesome-app@component:liquid-if::ember1420>

Installed everything afresh again and still the issue. Anyone experiencing the same?

(this is the same for liquid-bind and liquid-if)

@netes
Copy link

netes commented Sep 17, 2016

Confirmed, I've got the same issue when using Ember 2.8.

@ef4
Copy link
Collaborator

ef4 commented Sep 18, 2016

Can somebody share a reproduction? The test suite passes using liquid-fire 0.25 and Ember 2.8, and we don't make any direct use of attributeBindings.

@netes
Copy link

netes commented Sep 18, 2016

I only installed Ember 2.8 and the problem showed up, so there are no particular reproduction steps.

@ef4
Copy link
Collaborator

ef4 commented Sep 19, 2016

I only installed Ember 2.8 and the problem showed up, so there are no particular reproduction steps.

That is not enough detail to allow me to help. If I create a brand new ember app using ember 2.8 and liquid-fire 0.25.0 (or 0.26.1, which is now latest), and add a liquid-if, I don't get this error.

@ef4
Copy link
Collaborator

ef4 commented Sep 19, 2016

Also, as a random guess please check the second BREAKING change in the 0.25.0 notes and see if it applies to you.

@oscarni
Copy link

oscarni commented Sep 19, 2016

Got the exact same issue due to another addon which had an initalizer which added an attributeBinding to all my components without my direct knowledge. It made ember throw this error for all tagless components in my project. It might be worth investigating in your case if a brand new ember app does not throw this error.

In my case it was ember-hammertime adding some bindings, it's fixed now in master, just waiting for the new release.

@ef4
Copy link
Collaborator

ef4 commented Sep 19, 2016

Thanks @oscarni, that is helpful. Liquid fire uses tagless components, so any addon that does that would cause the this problem.

@deepflame
Copy link
Author

Thanks @oscarni . This was actually also the case for me.

Issue: html-next/ember-hammertime#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants