-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redis index deploy features. #91
Comments
Any one have any thoughts about the cache.manifest? |
Hi @arenoir... I think having the right hooks to support for a cache manifest is a good idea. I don't envy you though -- those things are a pain in the ass to deal with. Regarding writing the HTML content directly to the "current" key in redis, I would like for it to be easy for you to do this in your own addon. It would definitely not become the default behavior for a redis addon because it eliminates many of the benefits of the addon, such as preview and rollback support. Stay tuned to #88 and chime in if you think the hooks we are planning will not be sufficient to achieve what you need. |
@lukemelia thanks for the reply. I just pushed a pull request to ember-deploy-redis that allows writing directly to the content current key. Preview and rollback still work, I just moved where the version number was stored. |
I have nginx installed with the HTTP_REDIS module so it would be advantageous to have nginx serve the index.html file. However the nginx redis module is very limited. It is not easy to lookup the key and then use the key to fetch the content.
I am thinking a improved approach would be to copy the index content to the value of the current key thus eliminated the need for a lookup.
The second thing I ran into was wanting to store the html cache.manifest file in redis as well. I know cache.manifest is a bastard, but it does help with mobile.
Just wanted to run this by the team. I will most likely fork the ember-deploy-redis repo and implement this functionality.
🍻 to paving the cow paths.
Here is the nginx config; quite simple.
The text was updated successfully, but these errors were encountered: