Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fingerprinted assetMap.json files with v2.6.0 #122

Open
bschouwerwou opened this issue Sep 11, 2017 · 5 comments · May be fixed by #130
Open

Multiple fingerprinted assetMap.json files with v2.6.0 #122

bschouwerwou opened this issue Sep 11, 2017 · 5 comments · May be fixed by #130

Comments

@bschouwerwou
Copy link

bschouwerwou commented Sep 11, 2017

  • ember-cli 2.11.1
  • broccoli-asset-rev 2.6.0

I'm getting multiple assetMap.json files with v2.6.0 when I have fingerprintAssetMap: true. One file is correct, while the other is empty. Also of note is that the empty asset map file is included in the other.

assetMap-cd33192964e8c20af9391de38dbf449b.json:

{
  "assets": {
  },
  "prepend": "/"
}

assetMap-103a2cd1042363eeb87594e00d9ab623.json:

{
  "assets": {
    "assets/app.css": "assets/app-d41d8cd98f00b204e9800998ecf8427e.css",
    "assets/app.js": "assets/app-471ff2328e75d6c15e58dd5d046f5e9c.js",
    "assets/assetMap.json": "assets/assetMap-cd33192964e8c20af9391de38dbf449b.json",
    ...
  },
  "prepend": "/"
}

Having two files results in some production builds breaking because the empty asset map might be included. I didn't look into how it determines which file to load, but my guess is it's pulling in the first asset map it finds alphabetically, so it depends on the hashes being generated for each file and explains why its differs build to build.

Downgrading to 2.5.0 generates one file as expected.

@mydea
Copy link

mydea commented Feb 14, 2018

Any update on this? I am also experiencing this issue.

@josex2r
Copy link

josex2r commented Feb 20, 2020

Is #130 going to be merged? That branch fixed the same problem in my projects.

@amk221
Copy link

amk221 commented Apr 24, 2020

I need this too. Any update?

@joankaradimov
Copy link

Sadly there's been no activity in this repo for 2 years

@adrigzr
Copy link

adrigzr commented Jul 14, 2021

Any news? We need this so much 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants