Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve caching logic #61

Open
alexlafroscia opened this issue Sep 7, 2016 · 1 comment
Open

Improve caching logic #61

alexlafroscia opened this issue Sep 7, 2016 · 1 comment

Comments

@alexlafroscia
Copy link
Collaborator

alexlafroscia commented Sep 7, 2016

It's pretty clear that there are some issues with the caching, namely that configuration changes don't invalidate the cache. A number of issues have come up with that as the root problem:

I wanted to make an issue here as a reminder about this and a place to start gathering information for putting together a fix.


ESLint does provide a way to programmatically get the ESLint configuration for a particular file, namely the getConfigForFile function. Maybe we can use this information as part of the caching mechanism? My concern would be that this would be a pretty slow approach, but I don't know how poor the performance would actually be. I do feel like this might be a good approach because it would take any changes to the configuration into account, whether it's a change to a config file or adding things to an eslintignore, and would be robust going forward as long as their Node API does not change.

@alexlafroscia
Copy link
Collaborator Author

alexlafroscia commented Sep 7, 2016

Maybe I spoke too soon. It looks like we're already using that as part of the caching process...

@alexlafroscia alexlafroscia changed the title Improving caching logic Improve caching logic Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant