When deploy fails and --activate succeeds, a success code is returned

[joshsmith]

It appears that when a deploy fails but activation succeeds with the --activate command, the return is a success code for the activation. On my CI server this looks to me like a false positive.

Is this the expected behavior? Or should the whole thing fail? My guess is you don't even want to proceed with the activation in the event of a failing deploy.

[ghedamat]

@joshsmith it should definitely fail and not activate

I don't remember seeing this one, but thanks for reporting, we'll try to reproduce it and report back

[joshsmith]

@ghedamat I can tell you exactly what it failed on: I had provided a username (which is included by default in Redis Cloud's URL on Heroku). This username fails with the same error seen here: ember-cli-deploy/ember-cli-deploy-lightning-pack#9

While the username is a whole separate issue, I planned to take the URL dynamically from Heroku with my API key and use that for the Redis URL. Given that this URL could change, I'd prefer that over hamfisting it manually into my CI's env.

[ghedamat]

@joshsmith I think I've been able to reproduce, looks like the redis plugin is swallowing the error and preventing the pipeline from aborting, will investigate more soon

[ghedamat]

ok, here's the current status of my investigation

this is a problem related ONLY to ember-cli-deploy-redis

with the current version of then-redis that we're using in that plugin, when redis returns a parse error the redis library used doesn't seem to send the proper error event, because of that then-redisdoesn't receive it and we don't get a rejected promise, so we don't abort the pipeline.

It looks like then-redis is not maintained anymore https://github.com/mjackson/then-redis/issues/51 and that the current consensus is to use node-redis directly with bluebird

https://github.com/NodeRedis/node_redis#promises

I guess if I'm right and this is the problem we'll need a good PR to ember-cli-deploy-redis

/cc @achambers @lukemelia @joshsmith

[achambers]

Thanks for investigating @ghedamat

[lukemelia]

@ghedamat should we move this to ember-cli-deploy/ember-cli-deploy-redis?

[ghedamat]

@lukemelia I think so

[jordanyee]

For anyone else looking: this was moved to ember-cli-deploy/ember-cli-deploy-redis#36.

[achambers]

Closing this issue now in favour of ember-cli-deploy/ember-cli-deploy-redis/issues/51