Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template compilation broken on ember-cli < 3.13 in addons #754

Closed
ef4 opened this issue Sep 1, 2022 · 0 comments · Fixed by #755
Closed

Template compilation broken on ember-cli < 3.13 in addons #754

ef4 opened this issue Sep 1, 2022 · 0 comments · Fixed by #755
Assignees

Comments

@ef4
Copy link
Contributor

ef4 commented Sep 1, 2022

The changes introduces in ember-cli-htmlbars 6.1 may have broken support for ember-cli < 3.13 when used in addons. This was first noticed by @mansona in embroider-build/ember-auto-import#533

In that situation it looks like templates in addons don't go through babel after going through the template preprocessor, so they end up with untranspiled use of import { hbs } from 'ember-cli-htmlbars'.

The test suite here unfortunately doesn't really exercise any non-default ember-cli versions and doesn't include end-to-end testing of an addon's templates.

While these are super old versions to support, ember-cli-htmlbars 6 is supposed to work down to ember 3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants