Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parser options used when using the @typescript-eslint/parser parser #10046

Closed
bertdeblock opened this issue Oct 6, 2022 · 2 comments · Fixed by #10054
Closed

Incorrect parser options used when using the @typescript-eslint/parser parser #10046

bertdeblock opened this issue Oct 6, 2022 · 2 comments · Fixed by #10054

Comments

@bertdeblock
Copy link
Contributor

bertdeblock commented Oct 6, 2022

In the app blueprint's .eslintrc.js file, the sourceType and ecmaFeatures.legacyDecorators options are not valid options for the @typescript-eslint/parser parser.

We also specify sourceType for the Node override.

Valid options can be found here:
https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/parser#configuration

@Windvis
Copy link
Contributor

Windvis commented Oct 14, 2022

What options should we add for the typescript parser? Would something like what's documented in the typescript-eslint docs be good? (https://typescript-eslint.io/docs/linting/typed-linting)

@simonihmig
Copy link
Contributor

Good catch here!

What options should we add for the typescript parser?

I guess we should add as few options as possible, so only those that are really needed. Given that the setup now is working, it just has extraneous options, we can just remove those. Means everything but ecmaVersion, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants