You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The linking fix that went in to protect against data loss seems to prevent something like this from working: ln -s vendor/normalize-css/normalize.css app/styles/normalize.scss
Copying and pasting code from vendor should be discouraged.
Full reproducible copy/paste into terminal test scenario:
npm install -g ember-cli@0.0.22
ember new symlinktest
cd symlinktest
npm install --save-dev broccoli-sass
bower install normalize-css
# Workaround for https://github.com/joliss/broccoli-sass/pull/8
sed 's/preprocessCss(appAndDependencies/preprocessCss(appAndDependencies.inputTrees/g' Brocfile.js > tmp.js
rm Brocfile.js
mv tmp.js Brocfile.js
cd app/styles
ln -s ../../vendor/normalize-css/normalize.css normalize.scss
rm app.css
touch app.scss
echo "@import 'normalize';" >> app.scss
cd ../../
ember server
We need either:
A specified design pattern to account for this use case. (This would be an ember-cli issue, why this is filed.)
Address this as a bug in Broccoli. (Theoretically the data-loss issue only applicable to folders, so symlinking as I did should be "okay".) (This would probably be a broccoli-kitchen-sink-helpers or broccoli-filter issue.)
If we're ignoring 1 from above, feel free to close this. :)
now that the core of cli is approaching some stability, the addon story (including the issues you mention) will become our priority. Thanks for outlining the problem so nicely
When Broccoli pushes everything into the temporary directories the relative path symlink is no longer accurate. Presumably this worked previously because of hardlinks to the directories. This really isn't an ember-cli issue.
It is currently impossible to inline-include CSS from a vendored library using broccoli-sass.
ln -s vendor/normalize-css/normalize.css app/styles/normalize.scss
vendor
should be discouraged.Full reproducible copy/paste into terminal test scenario:
We need either:
If we're ignoring 1 from above, feel free to close this. :)
/cc @joliss
The text was updated successfully, but these errors were encountered: