New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging nested addon assets into vendor.css #3688
Comments
I don't believe we can rely on nested addons for this, as they can be duplicated (according to npm's dedupe). This is not compatible with what you want in vendor.css. How to solve this, and how to think about this is still a topic of further research. |
Thanks. Is this something that we want documented? I assume I won't be the only one thinking about nested addons in this fashion given that when running the dummy app during addon development, all appears well. |
I believe this needs further research before we can even document. We should be confident about are plans here. This likely should become an rfc we can iterate on "Non dup assets of nested addons" |
Sounds good however, this section on the change log is a little ambiguous. It reads (implicitly) as though what I was looking to achieve is possible. Lastly, is there a way to achieve my original even if not in vendor.css? Thanks again Stefan. |
On a similar note, it seems as though the nested component gets merged into the app space. I assume this is not intended given the this change log statement:
I could also have grave misunderstanding of how nested addons are supposed to work. |
Closing since this needs much more research. In the interim, I am able to get around this by placing the nested addon's assets in the parent addon. |
@stavarotti Did you copy it manually or did it with some scripts in Blueprint/index.js? |
I've looked at the addon docs on site in addition to the addon hooks page in the repo and am unable to find how to achieve merging a nested addon's assets into the app's vendor.css. Using the
included
hook seems to only work for the addon that is directly referenced in the main app (it does not work for the nested addon).I've also opened an SO question that further describes my setup and intent. I have not found any docs on how to achieve this hence the post here.
The text was updated successfully, but these errors were encountered: