Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing ember generate error messages #379

Closed
tomdale opened this issue Apr 16, 2014 · 1 comment
Closed

Confusing ember generate error messages #379

tomdale opened this issue Apr 16, 2014 · 1 comment

Comments

@tomdale
Copy link
Contributor

tomdale commented Apr 16, 2014

Invoking ember generate incorrectly causes either a confusing error message to be displayed, or a stack trace to get dumped:

➜  pdxbus  ember generate           
version: 0.0.23
generating from:
  - node_modules/loom-generators-ember-appkit/loom
-> You must specify a resource name, ie 'generate  user'

It looks like there is a bug in the generated example command because there are two spaces between generate and user.

If we do as it suggests (ember generate user):

version: 0.0.23
generating from:
  - node_modules/loom-generators-ember-appkit/loom
-> You must specify a resource name, ie 'generate user user'

I'm not sure what this is saying. Anyway, I wanted to create a new model:

version: 0.0.23
generating from:
  - node_modules/loom-generators-ember-appkit/loom

/Users/tomdale/Code/pdxbus/node_modules/loom-generators-ember-appkit/loom/generators/default.js:20
  var params = env.params;
                  ^
TypeError: Cannot read property 'params' of undefined
    at Object.generator.present (/Users/tomdale/Code/pdxbus/node_modules/loom-generators-ember-appkit/loom/generators/default.js:20:19)
    at Object.generator.present (/Users/tomdale/Code/pdxbus/node_modules/loom-generators-ember-appkit/loom/generators/model.js:8:23)
    at afterBefore (/usr/local/lib/node_modules/ember-cli/node_modules/loom/lib/runner.js:35:17)
    at Object.generator.before (/Users/tomdale/Code/pdxbus/node_modules/loom-generators-ember-appkit/loom/generators/default.js:15:5)
    at runGenerator (/usr/local/lib/node_modules/ember-cli/node_modules/loom/lib/runner.js:32:15)
    at /usr/local/lib/node_modules/ember-cli/node_modules/loom/lib/runner.js:26:7
    at /usr/local/lib/node_modules/ember-cli/node_modules/loom/lib/get_generator.js:12:14
    at Object.cb [as oncomplete] (fs.js:168:19)

I believe this stack trace is because there is no model generator (per https://github.com/cavneb/loom-generators-ember-appkit).

Two things:

  1. It looks like we need a model not found error.
  2. Since we ship with Ember Data by default, we should probably also have a model generator included as well.
@stefanpenner stefanpenner added this to the v0.0.24 milestone Apr 23, 2014
@stefanpenner
Copy link
Contributor

closing in favor of: #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants