Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-cli should determine LCA host and host addons for lazy engines #9501

Open
brendenpalmer opened this issue Mar 30, 2021 · 0 comments
Open

Comments

@brendenpalmer
Copy link
Contributor

Currently ember-engines is responsible for computing its host addons for deduplication purposes. To do this it uses a utility, findLCAHost, to find a common host for all lazy engines by the same name in the project: https://github.com/ember-engines/ember-engines/blob/master/packages/ember-engines/lib/utils/find-lca-host.js.

This issue is to track moving this functionality to ember-cli, so that ember-engines can later be updated to consume it from ember-cli if it exists, otherwise it'll fall back to its internal implementation. The idea is that with #9487, it's preferable to not have to duplicate the logic in multiple contexts, so that there's a single source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant