Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node 4 #102

Closed
jbandura opened this issue Jul 17, 2017 · 6 comments
Closed

Drop support for node 4 #102

jbandura opened this issue Jul 17, 2017 · 6 comments

Comments

@jbandura
Copy link
Collaborator

According to ember-cli's site, the node version supported is the latest LTS, which happens to be Node 6. This probably means that we can drop support for Node 4.

@ro0gr
Copy link
Contributor

ro0gr commented Jul 18, 2017

@jbandura can you provide the link where ember-cli site exactly defines node support matrix please?

I only found this one from repo:
https://github.com/ember-cli/ember-cli/blob/master/docs/node-support.md

Seems like node@4.2 is still supported.

@jbandura
Copy link
Collaborator Author

yes, you're right - I've been guiding myself by ember-best-practices plugin (which doesn't support node 4) and the LTS recommended section (not supported - misread that). But you're right - it's not explicilty stated that node 4 is not supported anymore - my bad.

@ro0gr
Copy link
Contributor

ro0gr commented Jul 18, 2017

No worries. I just was curious if there were such a statement in the cli docs.

@michalsnik
Copy link
Member

Ok so we're holding this proposition for now and will get back to this in a while.

@bryanhickerson
Copy link

I'm wondering if we can reconsider this issue. I'm hitting a node 4 specific failure in #239. Since the ember best practices plugin doesn't support node 4, it seems like it could be a barrier to migrating the ember best practices rules to eslint-plugin-ember.

@kellyselden
Copy link
Member

As soon as April 30th hits, kill it with fire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants