Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

--fix does not work in gjs/gts files #1750

Closed
NullVoxPopuli opened this issue Jan 21, 2023 · 3 comments 路 Fixed by #1853
Closed

--fix does not work in gjs/gts files #1750

NullVoxPopuli opened this issue Jan 21, 2023 · 3 comments 路 Fixed by #1853

Comments

@NullVoxPopuli
Copy link
Contributor

whoops.

馃檭

repro is easy:

  • have a gjs/gts with an autofixable error
  • run eslint path/to/file --fix
  • (nothing happens)
@patricklx
Copy link
Contributor

patricklx commented May 8, 2023

Hi, i found this:
eslint/eslint@0c720a3.

so, basically, exporting a supportsAutofix: true should be enough? since lines around transformed templates do not change?

edit: just tested it, it enabled the autofix, but location is wrong after template

@NullVoxPopuli
Copy link
Contributor Author

Seems good to iterate on tho, nice find!

@patricklx
Copy link
Contributor

its because it uses position instead of line/column. I have an idea to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants