Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

splattributes invalid conversion #112

Closed
knownasilya opened this issue Aug 20, 2019 · 2 comments · Fixed by #149
Closed

splattributes invalid conversion #112

knownasilya opened this issue Aug 20, 2019 · 2 comments · Fixed by #149

Comments

@knownasilya
Copy link

...attributes to ...attributes=""
@tylerturdenpants
Copy link
Collaborator

tylerturdenpants commented Aug 27, 2019 •
edited

@knownasilya nice! Haven't even attempted to address splattributes. BTW, can you think of any edge cases where splattributes might be invoked? Just making sure I dont miss anything. I will address this as soon as I get v2.0 out with ember-template-recast. You can follow the progress in #97

@knownasilya
Copy link
Author

They can be on any dom node and on other angle bracket components.

@Turbo87 Turbo87 mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test case for splattributes Turbo87/ember-angle-brackets-codemod
2 participants
@knownasilya @tylerturdenpants