route queryParams support

[jamesarosen]

If I do this in a route

export default MyRoute extends Route {
  queryParams = { foo: { refreshModel: true } }
}

then calling transitionTo(currentRoute, { queryParams: { foo: 'new-foo' } }) doesn't work. (In my tests, it seems to work on every other invocation, oddly.)

This works:

export default MyRoute extends Route {
  init() {
    super.init(...arguments)
    this.set('queryParams', { foo: { refreshModel: true } })
  }
}

as does this:

export default MyRoute extends Route {
  @computed // or without @computed
  get queryParams() {
    return { foo: { refreshModel: true } }
  }
}

This doesn't work:

export default MyRoute extends Route {
  constructor() {
    super()
    this.set('queryParams', { foo: { refreshModel: true } })
  }
}

because serializeQueryParam throws a null-pointer exception here trying to call this._router._serializeQueryParam(value, defaultValueType);

[pzuraq]

@jamesarosen I haven't been able to dig into this so far, but according to folks in the Typescript channel that I've talked to they've been able to use QPs by using class field assignment. I have a feeling the issues you're encountering may also be fixed by the changes proposed in RFC 337 as well.

Can you produce a test case or example of the failure?

[jamesarosen]

I suspect this is exactly what RFC 337 addresses.

[pzuraq]

This has been addressed in RFC337, the implementation of which has been merged and should be released soon