Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tricky behavior around build zip filenames #3

Open
mike-north opened this issue Nov 17, 2016 · 0 comments
Open

Tricky behavior around build zip filenames #3

mike-north opened this issue Nov 17, 2016 · 0 comments

Comments

@mike-north
Copy link

Because of the logic that fastboot-s3-downloader uses to extract output path from zip file names, any .zip filename without a dash in it will cause fastboot-aws to proceed with an outputPath of "" ultimately resulting in rimraf crashing when it tries to delete a path of "".

The error message the user gets is fairly cryptic (pretty sure this is the exact quote: something something rimraf became unhappy)

I suggest a few courses of action

  • in the instructions for fastboot-aws on ebs setup, mention that the filename should be something fairly consistent with the expected pattern (i.e., dist-0.zip)
  • add a few asserts along the way -- particularly considering that once you have your asset serving layer running on EBS, pulling the logs is not effortless, and in fact cannot be done while an environment is busy doing anything else at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant