-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom date format not being used in format-message #58
Comments
FWIW - I'm seeing the same thing happen with time formats too, |
You're absolutely correct, they should be returning the same results. I'll do some digging tonight as to what is going on. |
Ah, found the problem. So Will work for you: Full list of properties that will be treated as format options:Format date/time'localeMatcher', 'timeZone', 'hour12', 'formatMatcher', 'weekday', 'era', 'year', 'month', 'day', 'hour', 'minute', 'second','timeZoneName' Format relative'style', 'units' Format number'localeMatcher', 'style', 'currency', 'currencyDisplay', 'useGrouping', 'minimumIntegerDigits', 'minimumFractionDigits','maximumFractionDigits', 'minimumSignificantDigits', 'maximumSignificantDigits' |
1.1.4 published which will resolve this. Side note, phantom doesn't seem to like the weekday formatter, in case your tests fail phantom but pass in chrome. |
Awesome, thanks. Trust me to pick a reserved word for my first experiment! |
Just updated to 1.1.4 and can confirm this resolves the issue in my app. Thanks. |
I've added a custom date formatter to simply display the short form of a week-day, but that doesn't seem to be being used in a message. It's working with
format-date
but not withformat-message
.Here's an example repo containing an Ember app with the code below:
Eg:
This is then used in a message:
When displaying this in a template I'd expect the same date format to be shown:
But instead I get the following:
The text was updated successfully, but these errors were encountered: