Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to 2.0.0 #88

Closed
16 of 22 tasks
jasonmit opened this issue Mar 28, 2015 · 2 comments
Closed
16 of 22 tasks

Road to 2.0.0 #88

jasonmit opened this issue Mar 28, 2015 · 2 comments
Assignees

Comments

@jasonmit
Copy link
Member

Incomplete

  • Reverse the argument behavior of format-message
    • {{format-message 'path.to.foo.bar'}}
    • {{format-message (icu '{{population, number, integer} as of {census_date, date, long}}')}}
  • Warn with message when intl-get is passed a key that is not found (Can't get message translations in non-template code #107)
  • ember-browserify the intl deps
  • Provide a migration document with thorough instructions explaining upgrade path for breaking changes.

Completed

  • Move format message into its own formatter
    • Move the format computed prop out of service (mostly complete, format-message is last one)
  • Remove defaultLocale. Instead, declared in env configuration (the same config evaluated at build time)
  • leverage instance-initializer for injecting instead of initializer
  • Tests failing due to new addition of registry in the container. Will require changes to moduleForIntl
  • YAML translation file support
    • JSON translations are already supported, I'd like to support both for 2.0
  • When a translation is merged in from the default locale's translation file, throw a console warning at build time with the key(s) missing (mostly done, needs verifying for edge cases)
  • BREAKING: Translations now hang off translations (root folder) instead of app/locales
  • Automatically merge application default locale to all translations at build time
  • BREAKING: Translation files can be in two formats, json and yaml, instead of ES6 modules
    • JSON supported
    • Allows for easier third-party service serving translation assets
    • Commit: 411ea11
  • BREAKING: Translation modules no longer contain messages object. All translations hang off the exported parent object by default

Other

  • Move formatting logic out of service and into formatters. This will thin the service, and the service will simply proxy to the formatters
  • Remove support for 1.9 (Handlebars)
  • BREAKING: Intl service is now only injected via Ember.inject.service, no longer automatic as it's seldom needed and Ember now makes it convenient to inject services
  • ES6-ify
@jasonmit jasonmit changed the title Road to 2.0 Road to 2.0.0 Mar 28, 2015
@jasonmit
Copy link
Member Author

jasonmit commented Apr 1, 2015

Updated to reflected the YAML translation format proposal

/cc @ericf

@lxcodes
Copy link

lxcodes commented Jun 26, 2015

@jasonmit Is it possible to get out a beta1 before we complete some of the icu / path switching?

Trying to avoid our team getting a surprise at some point. Sadly we are still tracking this branch (/sadpanda) and then in beta2 release the switch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants