Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement widow template helper and apply to blog titles in the sidebar #50

Closed
2 tasks
mansona opened this issue Jun 11, 2020 · 0 comments · Fixed by #54
Closed
2 tasks

implement widow template helper and apply to blog titles in the sidebar #50

mansona opened this issue Jun 11, 2020 · 0 comments · Fixed by #54
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mansona
Copy link
Member

mansona commented Jun 11, 2020

In some cases the blog titles in the sidebar can be just long enough to wrap exactly one word onto the next line, which looks pretty bad. This is sometimes called a "widow" or an "orphan" and we can prevent it by replacing the last space in the line with a non breaking space  

Here is what it currently looks like:

Screenshot 2020-06-11 at 09 45 44

And here is what it looks like with the fix applied to the first line:

Screenshot 2020-06-11 at 09 49 20

To Do

  • create a no-widow helper that will replace the last space in the text passed to it with a non-breaking space
  • apply this helper to the titles of the tag sidebar

If you want to read more about widows and orphans you can see more here: https://en.wikipedia.org/wiki/Widows_and_orphans

@mansona mansona created this issue from a note in Emberify and Redesign the Ember Blog (To do) Jun 11, 2020
@mansona mansona added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 11, 2020
@nickschot nickschot self-assigned this Jun 11, 2020
@nickschot nickschot moved this from To do to In progress in Emberify and Redesign the Ember Blog Jun 11, 2020
@nickschot nickschot moved this from In progress to Needs review in Emberify and Redesign the Ember Blog Jun 11, 2020
Emberify and Redesign the Ember Blog automation moved this from Needs review to Done Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants