Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze Section: Components - Block Params #268

Closed
2 tasks
MelSumner opened this issue Nov 15, 2018 · 6 comments
Closed
2 tasks

Analyze Section: Components - Block Params #268

MelSumner opened this issue Nov 15, 2018 · 6 comments

Comments

@MelSumner
Copy link
Member

MelSumner commented Nov 15, 2018

Intro

This is part of a larger project that reviews the guide content to determine what, if any, updates need to be added to the guides as angle bracket and/or template-only components become the standard.

Sub-section to review:

Components - Block Params

Primary goals:

  • Review this sub-section: what needs to be updated for the new standards?
  • If analysis reveals that documentation is necessary, create a new issue with those tasks, and comment on this issue, linking to the new issue.
@MelSumner MelSumner created this issue from a note in Current Guide Analysis (To Do) Nov 15, 2018
@MelSumner MelSumner added the DecEmber December Hackathon label Nov 15, 2018
@MelSumner MelSumner changed the title Section: Components Section: Components - Block Params Nov 21, 2018
@MelSumner MelSumner changed the title Section: Components - Block Params Analyze Section: Components - Block Params Nov 29, 2018
@gossi
Copy link

gossi commented Dec 1, 2018

Yesterday I realized (has-block-params) is missing in this section. I've filed this ~a year ago: emberjs/guides#2135

Also the order of if statements in the template is important. It must be this way:

{{#if (has-block-params)}}
  block + block-params
{{else if (has-block)}}
  just block
{{else}
  inline
{{/if}}

@cah-danmonroe
Copy link
Contributor

Just a reminder that I have already submitted a PR #292 where I have already converted the 3.6 documentation to angle brackets. I can address further #issues from there.

@locks
Copy link
Contributor

locks commented Dec 12, 2018

Addressed by #292.

@gossi I am closing this issue as that specific concern is unrelated to Octane/new component syntax. Can you open a separate issue in this repository?

@locks locks closed this as completed Dec 12, 2018
Current Guide Analysis automation moved this from To Do to Done Dec 12, 2018
@gossi
Copy link

gossi commented Dec 13, 2018

Erm maybe I missunderstand this. But PR #292 hasn't covered (has-block-params) yet and yes this issue is unrelated to Octane but applies to the current ember version/guides, which this issue is about - so I am confused now, why I should open another ticket, which would just be a clone of that.

@locks
Copy link
Contributor

locks commented Dec 14, 2018

Issue filed.

@locks
Copy link
Contributor

locks commented Feb 13, 2019

#441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants