You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a button component that yields several named blocks for various reasons (mostly used by other re-usable components). The rule require-presentational-children fails whenever we add e.g. role="tab" to one of these buttons:
has a role of tab, it cannot have semantic descendants like <:default>
I think named blocks should not be flagged like this, rather the contents should be evaluated instead (if anything). The result is now that people are encouraged to remove the role attribute or suppress the lint rule, as those are the only ways to fix the error.
The text was updated successfully, but these errors were encountered:
We have a button component that yields several named blocks for various reasons (mostly used by other re-usable components). The rule
require-presentational-children
fails whenever we add e.g.role="tab"
to one of these buttons:Fails with the error
I think named blocks should not be flagged like this, rather the contents should be evaluated instead (if anything). The result is now that people are encouraged to remove the role attribute or suppress the lint rule, as those are the only ways to fix the error.
The text was updated successfully, but these errors were encountered: