Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release #44

Open
4 tasks done
evoactivity opened this issue Feb 12, 2024 · 6 comments
Open
4 tasks done

Prepare for release #44

evoactivity opened this issue Feb 12, 2024 · 6 comments

Comments

@evoactivity
Copy link
Member

evoactivity commented Feb 12, 2024

  • Add VSCODE_STORE_TOKEN secret
  • Add OPEN_VSX_STORE_TOKEN secret
  • Update package.json package.json changes #43
  • Make workflow manually runnable
@lifeart
Copy link
Contributor

lifeart commented Feb 13, 2024

@evoactivity in addition, we need to check locally if any issues appears if user has both official & unstable els installed and enabled. And if some - we need to land proper changes to any to avoid conflicts

@evoactivity
Copy link
Member Author

We could detect in uELS if ELS is installed and bail out, printing a message to the output that ELS should be disabled to use uELS. What do you think?

@lifeart
Copy link
Contributor

lifeart commented Feb 13, 2024

@evoactivity yep, we should be able to get list of enabled extensions

@evoactivity
Copy link
Member Author

Extension has been un-deprecated. I'm aiming to get things release this week.

@evoactivity
Copy link
Member Author

The release to the vscode marketplace worked
https://marketplace.visualstudio.com/items?itemName=EmberTooling.vscode-ember

Open VSX is being a silly little goose, so I've contacted them to fix the account.

❌  Your Publisher Agreement with the Eclipse Foundation is outdated (version 1.0). The current version is 1.

image

@evoactivity
Copy link
Member Author

https://open-vsx.org/extension/embertooling/vscode-ember

open vsx fixed their issue and release now working 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants