Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_client_proof does not use leading zeros for salt parameter #28

Closed
username223 opened this issue Mar 30, 2021 · 1 comment
Closed

Comments

@username223
Copy link
Contributor

The function uses detail::encode_flip() which does not add padding.

From experimentation with the 1.12.1 client, this will result in incorrect proofs.

Changing

	const auto& salt_enc = detail::encode_flip(salt);

to

    const auto& salt_enc = detail::encode_flip_1363(salt, 32);

Seems to fix the problem.

There are other parameters in the function that also do not add padding, although I haven't gotten around to testing these yet.

@username223
Copy link
Contributor Author

I accidentally used an old version of the development branch. This has already been fixed for salt as part of issue #27 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant