-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModalPane's callback doesn't work #36
Comments
Yeah, the modal pane has been broken for quite a while with ember 1.0.pre whilst setting a This is how I've currently hacked it to work in my app. I'll get a test and PR (a different fix though) for it up in the next couple of days, thanks for the minimal app. Bootstrap.ModalPane.reopen({
_triggerCallbackAndDestroy: function(options, event){
this._super(options, event);
App.router.applicationController.set('modal', null);
}
});
Bootstrap.ModalPane.reopenClass({
popup: function(options) {
var modalPane;
if (!options) options = {};
modalPane = this.create(options);
App.router.applicationController.set('modal', modalPane);
return modalPane;
}
}); |
Here's a better short-term fix: Bootstrap.ModalPane.reopenClass({
popup: function(options) {
var modalPane;
if (!options) options = {};
modalPane = this.create(options);
modalPane.appendTo(App.rootElement);
return modalPane;
}
}); |
I haven't tested the following, but won't appending the backdrop to the root element rather than |
Hi,
I was having trouble with the
ModalPane
'scallback
, and I created a minimal app in a jsfiddle:http://jsfiddle.net/siovene/n29y7/
The
callback
function is never called onclick
, but only onkeypress
if I hitESC
.Thanks in advance for looking into this.
The text was updated successfully, but these errors were encountered: