Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change isDirty flag to something like hasDirtyAttributes #3299

Closed
igorT opened this issue Jun 11, 2015 · 3 comments
Closed

Change isDirty flag to something like hasDirtyAttributes #3299

igorT opened this issue Jun 11, 2015 · 3 comments

Comments

@igorT
Copy link
Member

igorT commented Jun 11, 2015

Same rationale as #3273
@igorT igorT mentioned this issue Jun 11, 2015
Closed
10 tasks
@igorT igorT changed the title Consider changing isDirty flag to something like areAttributesDirty Change isDirty flag to something like hasDirtyAttributes Jun 11, 2015
@HeroicEric
Copy link
Sponsor Member

I went to work on this but I'm not sure how to deprecate model.get('isDirty'). Any guidance?

@sly7-7
Copy link
Contributor

sly7-7 commented Jun 12, 2015

maybe implementing the unknownProperty method and throwing deprecation if the passed property is ìsDirty`?

@wecc
Copy link
Contributor

wecc commented Jun 30, 2015

Fixed by #3351

@wecc wecc closed this as completed Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@HeroicEric @wecc @igorT @sly7-7