Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlForDeleteRecord doesn't appear in docs #4707

Closed
caseywatts opened this issue Dec 9, 2016 · 5 comments
Closed

urlForDeleteRecord doesn't appear in docs #4707

caseywatts opened this issue Dec 9, 2016 · 5 comments
Labels
🏷️ doc This PR adds/improves/or fixes documentation

Comments

@caseywatts
Copy link

I would expect this method to appear in the docs here:
http://emberjs.com/api/data/classes/DS.RESTAdapter.html

It looks like maybe it's accidentally commented out in the version linked to from the docs.
https://github.com/emberjs/data/blob/v2.10.0/addon/-private/adapters/build-url-mixin.js#L363

It looks like it's fixed (not commented out) on master, - just the docs aren't updated to reflect this yet:
https://github.com/emberjs/data/blob/master/addon/-private/adapters/build-url-mixin.js#L363

@btecu
Copy link
Contributor

btecu commented Dec 11, 2016

@wecc
Copy link
Contributor

wecc commented Dec 11, 2016

@bmac @pangratz would adding #4590 to release make the 2.10 docs reflect the change?

@pangratz
Copy link
Member

I am not familiar with how the docs are deployed 😔

@caseywatts
Copy link
Author

urlForUpdateRecord does show up in the docs as expected, but urlForDeleteRecord does not :)
Thanks for looking into this everyone !

@pangratz
Copy link
Member

pangratz commented Apr 5, 2017

I am closing this as it seems to be showing up in the API docs now https://emberjs.com/api/data/classes/DS.RESTAdapter.html#method_urlForDeleteRecord

@pangratz pangratz closed this as completed Apr 5, 2017
@runspired runspired added 🏷️ doc This PR adds/improves/or fixes documentation and removed Documentation labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ doc This PR adds/improves/or fixes documentation
Projects
None yet
Development

No branches or pull requests

5 participants