Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: filter recordArrays must be deleted #4825

Closed
stefanpenner opened this issue Feb 27, 2017 · 3 comments
Closed

DOC: filter recordArrays must be deleted #4825

stefanpenner opened this issue Feb 27, 2017 · 3 comments
Labels
🏷️ doc This PR adds/improves/or fixes documentation

Comments

@stefanpenner
Copy link
Member

#4041 suggest that we must improve documentation around how and when to cleanup recordArrays.

@oliw
Copy link

oliw commented Mar 23, 2017

In case this helps shape your Dos and Donts this is how I'm cleaning up my record Arrays

  model() {
    let serviceRegionIds = this.paramsFor('service-region-group').service_region_group_id.split(',');
    return this.store.filter('chat-participant', participant => serviceRegionIds.includes(participant.get('serviceRegionId')));
  },

  deactivate() {
    // Ember Data #4041 - store#filter/store#query RecordArrays
    // are never garbage collected
    const model = this.get('controller.model');
    model.destroy();
  }

@runspired
Copy link
Contributor

@runspired runspired changed the title DOC: recordArrays must be deleted DOC: filter recordArrays must be deleted Apr 19, 2018
@runspired
Copy link
Contributor

we no longer have filtered record arrays at all.

@runspired runspired added 🏷️ doc This PR adds/improves/or fixes documentation and removed Documentation labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ doc This PR adds/improves/or fixes documentation
Projects
None yet
Development

No branches or pull requests

3 participants