Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in ensureSameTransaction method #508

Closed
mpelos opened this issue Dec 7, 2012 · 4 comments
Closed

Bug in ensureSameTransaction method #508

mpelos opened this issue Dec 7, 2012 · 4 comments
Labels
🏷️ bug This PR primarily fixes a reported issue Needs Bug Verification

Comments

@mpelos
Copy link

mpelos commented Dec 7, 2012

I think this method should return a Transaction instance, but instead it's returning a javascript array.

When I call deleteRecord on a Model instance that has a belongsTo association this error is raised:
TypeError: Object DS.Transaction:ember2444,DS.Transaction:ember2444,App.Message:ember340,App.User:ember432 has no method 'relationshipBecameDirty'

This occurs when sync method make this call:
this.ensureSameTransaction(child, oldParent, newParent, hasManyName, belongsToName).relationshipBecameDirty(this);

The ensureSameTransaction method returns an array and the call to the method relationshipBecameDirty raises the error.

@trek
Copy link
Member

trek commented Dec 10, 2012

That seems bad. @tomdale any thoughts?

@sly7-7
Copy link
Contributor

sly7-7 commented Apr 19, 2013

@mpelos Could you please check this against latest ember-data ?

@tomdale
Copy link
Member

tomdale commented Apr 19, 2013

A significant number of changes to the transaction code have been made since this issue was filed. @mpelos, I'm going to close the ticket, but can you please comment here if you are still having issues?

@tomdale tomdale closed this as completed Apr 19, 2013
@mpelos
Copy link
Author

mpelos commented Apr 20, 2013

Thank you Tom. I don't have more issues, for now.

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue Needs Bug Verification
Projects
None yet
Development

No branches or pull requests

5 participants