Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model.reload should take adapterOptions #5373

Closed
kjf opened this issue Mar 9, 2018 · 1 comment
Closed

model.reload should take adapterOptions #5373

kjf opened this issue Mar 9, 2018 · 1 comment
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@kjf
Copy link

kjf commented Mar 9, 2018

When using methods like store.findRecord, it’s possible to pass in adapterOptions that can be accessed on urlForFindRecord and used to change the url. However when calling model.reload() there doesn’t seem to be a way to pass in these same adapterOptions so urlForFindRecord is subsequently called but adapterOptions is unavailable.
@bmac bmac added the Bug label Mar 13, 2018
@bmac
Copy link
Member

bmac commented Mar 13, 2018

This is an oversight that should be fixed.

@runspired runspired mentioned this issue Apr 4, 2018
Merged
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kjf @bmac @runspired