Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug][regression] infinite find record triggered from view #5479

Closed
vadim-p opened this issue May 28, 2018 · 2 comments
Closed

[bug][regression] infinite find record triggered from view #5479

vadim-p opened this issue May 28, 2018 · 2 comments

Comments

@vadim-p
Copy link

vadim-p commented May 28, 2018

Failed record fetch, initiated from view (ex: record.relationship.relAttr in .hbs), will retry request infinite number of times.

Repo with example.
In example, in index route, there are infinite loop of request to /preset-filters/:id.
Same for belongsTo relationship type.

This issue occurs after this #5376 merge.
With ember-data@3.0.2 it breaks on first retry because of TypeError:

GET http://localhost:4200/preset-filters/1 404 (Not Found)
Uncaught TypeError: Cannot read property 'eachAttribute' of null 
    at new Snapshot (-private.js:5041)
    at InternalModel.createSnapshot (-private.js:6940)
    at _find (-private.js:8546)
    at Class._fetchRecord (-private.js:10378)
    at _fetchRecord (-private.js:10441)
    at Class._flushPendingFetchForType (-private.js:10539)
    at cb (ember-metal.js:5356)
    at OrderedSet.forEach (ember-metal.js:5169)
    at MapWithDefault.forEach (ember-metal.js:5364)
    at Class.flushAllPendingFetches (-private.js:10421)
ember-cli: 3.1.4
ember-source: 3.1.2
ember-data: 3.1.1
@runspired
Copy link
Contributor

@vadim-p could you check if this is still an issue on master or at least on the latest 3.2 ? I suspect I fixed it already.

@vadim-p
Copy link
Author

vadim-p commented Jun 4, 2018

@runspired, unfortunately problem persists.

Ember      : 3.2.0
Ember Data : 3.3.0-canary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants