Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #5467 (work during destroy) to 3.1/2.18 #5578

Closed
runspired opened this issue Aug 21, 2018 · 2 comments
Closed

Backport #5467 (work during destroy) to 3.1/2.18 #5578

runspired opened this issue Aug 21, 2018 · 2 comments

Comments

@runspired
Copy link
Contributor

The fix in #5467 helps to prevent issues with ember.js version 3.3, it is likely we should backport it at least that far.
@runspired runspired mentioned this issue Aug 21, 2018
Closed
@jherdman
Copy link

I'm going to take this on.

@runspired
Copy link
Contributor Author

Turns out this was backported to 3.2/3.3 already. We should backport to 3.1/2.18 to catch more folks that haven't upgraded and are still re-reporting the issue.

@jherdman jherdman mentioned this issue Aug 22, 2018
Merged
@runspired runspired changed the title Backport #5467 to 3.3 Backport #5467 to 3.1/2.18 Aug 27, 2018
@runspired runspired changed the title Backport #5467 to 3.1/2.18 Backport #5467 (work during destroy) to 3.1/2.18 Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jherdman @runspired