Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS.RecordArray has no reference to Ember.Enumerable#reject #742

Closed
tricknotes opened this issue Feb 20, 2013 · 3 comments
Closed

DS.RecordArray has no reference to Ember.Enumerable#reject #742

tricknotes opened this issue Feb 20, 2013 · 3 comments
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@tricknotes
Copy link
Member

I cannot use Ember.Enumerable#reject from DS.RecordArray.
This cause is that DS.RecordArray#reject references Ember.DeferredMixin#reject.

DS.RecordArray has conflict of mixin's method name.

@igorT
Copy link
Member

igorT commented Apr 15, 2013

Yup, this will take a while to fix, I think RSVP 2.0 doesn't have reject so once ember switches to it it will be fine. There is a failing test at #861

@wagenet
Copy link
Member

wagenet commented Aug 10, 2013

Seems like this will be fixed by the extraction of Promises that @wycats, @tomdale and @stefanpenner have been pursuing.

@tricknotes
Copy link
Member Author

This issue was fixed.
ref: #861 (comment)

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

No branches or pull requests

4 participants